π‘οΈ Sentinel: [HIGH] Fix RPC error information disclosure#42
π‘οΈ Sentinel: [HIGH] Fix RPC error information disclosure#42DerUntote wants to merge 1 commit into
Conversation
Removed direct passing of daemon RPC error messages to Discord users in all Tipper modules. This prevents the exposure of sensitive infrastructure details to end-users. Replaced with generic error messages and internal console logging. Also added missing .catch() handlers on message.delete() calls to prevent unhandled promise rejections. Added journal entry to .jules/sentinel.md. Co-authored-by: DerUntote <8378077+DerUntote@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Internal RPC error messages from bitcoind-rpc connections were directly passed to Discord users via
message.reply(err.message), potentially exposing sensitive infrastructure details. Additionally,.catch()handlers were missing on the subsequentmessage.delete()calls.π― Impact: Sending raw daemon error messages to end-users is an information disclosure vulnerability. Missing
.catch()handlers on Discord API calls can crash the bot due to unhandled promise rejections.π§ Fix: Replaced
message.reply(err.message)withconsole.error(err)and a generic reply message. Appended.catch(() => {})tomessage.delete()calls. Added a journal entry to.jules/sentinel.md.β Verification: Ran
yarn precommitandnode -con all modified files to verify syntax. Checked thatmessage.reply(err.message)no longer exists inbot/modules.PR created automatically by Jules for task 13049785410705347006 started by @DerUntote