Add extensible user registration flow - #170
Merged
Merged
Conversation
- RegistrationFlow/RegistrationStep model in central and auth (OTP, SetPassword, PasskeyEnroll) - registration_flow column on oauth_clients with InvalidRegistrationConfiguration validation - Silent login for existing credentials during registration (anti-enumeration) - User registration outbox to sync accounts from auth to central - Patch[T] semantics for authFlow, registrationFlow, and logout URI configuration updates - central-ui registration flow configuration UI - e2e RegistrationFlowSpec
# Conflicts: # auth/src/main/scala/versola/oauth/authorize/AuthorizeEndpointService.scala # auth/src/main/scala/versola/oauth/conversation/ConversationRouter.scala
goshacodes
marked this pull request as ready for review
August 13, 2026 18:35
Member
Author
|
augment review |
Contributor
|
|
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
goshacodes
force-pushed
the
feat/user-registration
branch
from
August 15, 2026 10:01
2704d46 to
3bd3a27
Compare
Member
Author
|
augment review |
Contributor
|
This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it. |
Member
Author
|
augment review |
Contributor
There was a problem hiding this comment.
Review completed. 3 suggestions posted.
Items Reviewed
- ✅ Registration flow routing and step advancement in ConversationRouter
- ✅ Deferred account creation and OTP verification ordering
- ✅ Central user-index claim (indexFromAuth) concurrency and conflict handling
- ✅ Patch[T] semantics for authFlow/registrationFlow/logout URIs
- ✅ Registration flow configuration validation in Central
- ✅ Central UI client-form registration settings and API serialization
- ✅ Auth OTP faking / account-enumeration behaviour
- ✅ UserRolesRepository consolidation into UserRepository
- ✅ Test coverage for new registration paths
Comment augment review to trigger a new review at any time.
goshacodes
force-pushed
the
feat/user-registration
branch
from
August 15, 2026 12:13
b97e0b7 to
a01f01f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RegistrationFlow/RegistrationStep) with ordered OTP, Password, and Passkey steps and room for future step types.POST /users/registrations.UserControlleratPOST /users/registrations.registration_flowto Central OAuth clients (V1018) and snapshots the flow and current step in Auth conversations (V0011). No Auth registration-outbox migration is required.Patch[T]semantics toauthFlow,registrationFlow,frontChannelLogoutUri, andbackChannelLogoutUri, distinguishing absent, explicitnull, and set values.userrole and consolidates Auth role persistence intoUserRepository.Testing
sbt "central/test"— 313 tests passed, 0 failed.sbt "auth/test"— 709 tests passed, 0 failed.sbt "central-postgres-impl/compile"— passed.RegistrationFlowSpeccovers phone/email registration, configured registration steps, and existing-user fallback. Running it locally requires generated form assets and a freshly seeded live stack.Pull Request opened by Augment Code | View session