Skip to content

Add Release Action - #108

Merged
fralken merged 6 commits into
versat:masterfrom
SunNathan:feat/release_actions
Mar 5, 2024
Merged

Add Release Action#108
fralken merged 6 commits into
versat:masterfrom
SunNathan:feat/release_actions

Conversation

@SunNathan

@SunNathan SunNathan commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

This PR adds:

  • 2 github actions to automate the build of release artifacts.

(To activate the build, simply create a tag, and artifacts will be added automatically).

If you have any questions or suggestions for improvement, feel free to ask!

Here's a sample result:
Annotation 2024-03-05 092113

(close #71)

@versat
versat requested a review from fralken March 5, 2024 10:16
@versat

versat commented Mar 5, 2024

Copy link
Copy Markdown
Owner

@fralken This looks great to me. You also played around with release workflows, what do you think?

@fralken

fralken commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator

Yes last year I made a release workflow. It is a single file using the matrix strategy.
I didn't merge it here because my idea was also to add a release for macOS but then I never found time to investigate on it.
I'm not sure if it is better to have a single workflow file dedicated to all the releases or a workflow file for each platform.

Comment thread .github/workflows/windows_release.yml Outdated
Comment thread .github/workflows/ubuntu_release.yml Outdated
@sonarqubecloud

sonarqubecloud Bot commented Mar 5, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fralken

fralken commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator

It looks good to me, too. It can be merged. Thanks a lot for this.

Anyway, I would wait creating a tag triggering the release until @gs-kamnas completes PR #97

@fralken
fralken merged commit 85a14ad into versat:master Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Are the build binaries avialable?

3 participants