Simple fixes#14
Open
jvtrigueros wants to merge 9 commits into
Open
Conversation
This causes a nasty error while loading up the REPL. I was a bit confused at first but then I realized this ns didn't exist.
Both of these keys are used by post-to-slack and format-result-for-slack
As per the Slack API documentation, you don't provide a URL to respond to, instead you are given a URL that you should POST results back to.
`format-result-for-slack` expects a certain kind of map. The code has access to this map already, but a different one is sent instead.
`:post-url` shouldn't be mentioned as it is no longer needed
enforser
reviewed
Nov 5, 2018
enforser
reviewed
Nov 5, 2018
enforser
reviewed
Nov 5, 2018
enforser
reviewed
Nov 5, 2018
Author
|
Thanks for the feedback! I'll address them and re-submit :) |
Author
|
@enforser I've made the changes requested, please review at your earliest convenience! |
enforser
approved these changes
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for giving me a starting point for creating a Slash Command for my Slack group.
Now, right out of the box, I couldn't get this working, and I noticed a few things were off, so I decided that instead of fixing it and moving on, I should offer them back to you, anyway here's a summary:
:init-nsfromproject.cljwas causing errors when using REPL:response_urland:userkeys to the:metamap, they are needed:post-urland use:response_urlthat is given to you on the initial POST