Skip to content

[ci] fix: remove hf endpoint override#37

Closed
Luosuu wants to merge 4 commits into
verl-project:mainfrom
Luosuu:codex/remove-hf-endpoint
Closed

[ci] fix: remove hf endpoint override#37
Luosuu wants to merge 4 commits into
verl-project:mainfrom
Luosuu:codex/remove-hf-endpoint

Conversation

@Luosuu

@Luosuu Luosuu commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the GPU CI workflow-level HF_ENDPOINT override
  • remove the matching env -u HF_ENDPOINT wrappers from model and dataset downloads

Tests

  • bash -n .github/scripts/run_gpu_tests.sh .github/scripts/run_verl_smoke.sh
  • git diff --check
  • rg --line-number "HF_ENDPOINT" .github (no matches)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the env -u HF_ENDPOINT prefix from the Hugging Face download commands in both .github/scripts/run_gpu_tests.sh and .github/scripts/run_verl_smoke.sh, allowing the commands to respect the HF_ENDPOINT environment variable if set. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Luosuu Luosuu closed this Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant