Skip to content

fix(jira-integration): Harden Jira URL matching in “Closes …” lists #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marek-saji merged 4 commits into from
Jul 15, 2026
Merged

fix(jira-integration): Harden Jira URL matching in “Closes …” lists #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bcb4e69
fix(jira-integration): Match angle-bracket-wrapped Jira URLs
marek-saji Jul 9, 2026
4865cf4
fix(jira-integration): Avoid crash on case-variant Jira URLs
marek-saji Jul 9, 2026
82ff77a
fix(jira-integration): Escape Jira origin in URL regexp
marek-saji Jul 9, 2026
e4ff700
chore: Move .nvmrc to repo root, bump to Node 24
marek-saji Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v24.18.0
1 change: 0 additions & 1 deletion jira-integration/.nvmrc
View file
Open in desktop

This file was deleted.

10 changes: 5 additions & 5 deletions jira-integration/dist/index.mjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions jira-integration/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,8 @@ function extractResolvedIssueKeys(prBody, comments) {
// It’s extremely important for this regexp to match only simple
// jira keys as extracted keys will be used in JQL queries.
const issueKeyRegExp = '[A-Z][A-Z0-9]+-[0-9]+'
const urlRegExp = `${jiraApiBaseUrl.origin}/browse/(${issueKeyRegExp})`
const closesRegExp = `${keywordsRegExp}${urlRegExp}(?:\\s*,\\s*${urlRegExp})*`
const urlRegExp = `${RegExp.escape(jiraApiBaseUrl.origin)}/browse/(${issueKeyRegExp})`
const closesRegExp = `${keywordsRegExp}<?${urlRegExp}>?(?:\\s*,\\s*<?${urlRegExp}>?)*`

// Find all “Closes URL, URL…”
const matches = text.match(new RegExp(closesRegExp, 'gi')) || []
Expand All @@ -187,10 +187,10 @@ function extractResolvedIssueKeys(prBody, comments) {
new Set(
matches.flatMap((match) => {
// Find URLs
const urlMatches = match.match(new RegExp(urlRegExp, 'g'))
const urlMatches = match.match(new RegExp(urlRegExp, 'gi'))
// Find issueId in the URL (only capture group in urlRegExp)
const issueKeys = urlMatches.map(
(url) => url.match(new RegExp(urlRegExp))[1]
const issueKeys = urlMatches.map((url) =>
url.match(new RegExp(urlRegExp, 'i'))[1].toUpperCase()
)
return issueKeys
})
Expand Down