fix(ai): preserve tool approval signature when transitioning to appro…#16558
Open
luluwux wants to merge 1 commit into
Open
fix(ai): preserve tool approval signature when transitioning to appro…#16558luluwux wants to merge 1 commit into
luluwux wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When
experimental_toolApprovalSecretis configured, resuming after a tool approval fails withAI_InvalidToolApprovalSignatureError: missing signature.This happens because the client-side state manager drops
approval.signaturewhen transitioning from theapproval-requestedstate to theapproval-respondedstate in two places:AbstractChat.addToolApprovalResponse(manual approval) — rebuiltapprovalas{ id, approved, reason }without carrying forwardsignature.processUIMessageStreamunder thetool-approval-responsecase (streamed/automatic) — rebuilttoolInvocation.approvalcarryingisAutomaticbut omittingsignature.Consequently,
convertToModelMessageslater readpart.approval.signatureasundefined, causing the server-side verification check to throw.Summary
addToolApprovalResponseto preservepart.approval.signaturewhen mapping and updating message parts.tool-approval-responsecase to carry forward the previousapproval.signatureinto the updatedtoolInvocation.approvalobject.approved with signatureunit test to verify signature preservation for manual approvals.automatic tool approval signature preservationunit test to verify signature preservation for streamed/automatic approvals.Manual Verification
Checklist
Note
Please make sure to sign your commits as required by the repository guidelines before merging.
Related Issues
Fixes #16543