fix (gateway): forward non-gateway provider options under gateway.providerOptions for fallback model support#16502
Open
kairosci wants to merge 2 commits into
Open
Conversation
…viderOptions for fallback model support
kairosci
force-pushed
the
gateway-fallback-provider-options
branch
from
a0c363f to
e2c9166
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provider-specific options (e.g.,
google.thinkingConfig) specified at the top level ofproviderOptionswere being ignored when the gateway routed to a fallback model fromgateway.modelsorgateway.order. The gateway API server appliesproviderOptions.<provider>only for the primary model, not for any fallback model selected at runtime.Changes
A new
providerOptionsfield was added to theGatewayProviderOptionstype, providing a mechanism to associate options with any provider the gateway might route to.GatewayLanguageModel.getArgs()was updated to auto-nest all non-gateway provider options undergateway.providerOptionsbefore sending the request, so the server can read and apply the correct options regardless of which model (primary or fallback) is selected. 4 regression tests were added covering nesting for doGenerate, nesting for doStream, no-op when no non-gateway options exist, and preservation of top-level options for backward compatibility.The change is transparent to users: the public API is unchanged, and the SDK automatically populates the new field from existing top-level provider options.
Closes #14377