fix(cli): coerce leading numeric flag values (e.g. 1.5s → 1.5)#54
Open
EfeDurmaz16 wants to merge 2 commits into
Open
fix(cli): coerce leading numeric flag values (e.g. 1.5s → 1.5)#54EfeDurmaz16 wants to merge 2 commits into
1.5s → 1.5)#54EfeDurmaz16 wants to merge 2 commits into
Conversation
|
@EfeDurmaz16 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Hey! Thanks for the PR. I rather have |
Per review: keep parseFloat leniency so '1.5s' -> 1.5 and '1abc' -> 1, using a leading-number regexp guard so values with no leading number (e.g. 'abc') are still rejected. Update tests to assert coercion.
EfeDurmaz16
changed the title
1.5s → 1.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses @atinux's review: instead of rejecting partial numeric values, coerce the leading number (parseFloat-style) so
--temperature 1.5s/--duration 2mswork (→1.5/2). A leading-number regexp keepsparseFloatfrom being too permissive, so values with no leading number (e.g.abc) are still rejected.Behavior
1.5s→1.5,1abc→1,.5x→0.5abc(no leading number) → still errorsTests
bun test packages/ai-cli/src/lib/parse.test.ts(20 pass)bun run typecheckbun run format:check