fix: guard against empty choices and message=None across all model backends#48
Open
qizwiz wants to merge 1 commit into
Open
fix: guard against empty choices and message=None across all model backends#48qizwiz wants to merge 1 commit into
qizwiz wants to merge 1 commit into
Conversation
…ckends All four model backends (OpenAI, Azure, Cerebras, Groq) access response.choices[0].message.content without checking whether choices is non-empty or message is non-None. The API can return choices=[] on content-policy rejections or provider errors, and choices[0].message=None (e.g. Gemini PROHIBITED_CONTENT via OpenAI-compatible endpoint, HTTP 200 with finish_reason=PROHIBITED_CONTENT). Both crash with IndexError or AttributeError. Explicit guards raise ValueError instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add explicit guards in all four model backend classes before accessing
response.choices[0].message.content.Why
client.chat.completions.create()can return two empty-response shapes, neither currently handled:choices = []— on content-policy rejections, rate-limit errors, or provider failureschoices[0].message = None— e.g. Gemini 2.5 Flash via the OpenAI-compatible endpoint returns HTTP 200 withfinish_reason: PROHIBITED_CONTENTandmessage=NoneBoth crash with
IndexErrororAttributeError. All four model backends have identical unguarded access patterns.Files changed
common/models/openai_model.pychoices[0].message.contentcommon/models/azure_model.pychoices[0].message.contentcommon/models/cerebras_model.pychoices[0].message.contentcommon/models/groq_model.pychoices[0].message.contentCorpus context
Detected by
pact(llm_response_unguardedmode), a Z3-verified static analyzer for LLM crash vectors. This pattern was found across 13.7k violations in 786 repos.