chore(natsjs): bump go directive to 1.26#14
Open
DereviankoSergey wants to merge 1 commit into
Open
Conversation
Phase 1 of the NATS clients migration (VLM-4674). natsjs/v2 module: - bump github.com/nats-io/nats.go v1.25.0 -> v1.52.0 - bump go directive 1.19 -> 1.26 - go mod tidy CI (.github/workflows/github-ci.yml): - go-version 1.19 -> 1.26 in linter and tests jobs (fixes build: crypto/ecdh, slices not in GOROOT) - update actions: setup-go v5, checkout v4, golangci-lint-action v7 (golangci-lint v2.x) .golangci.yml: migrate v1 -> v2 schema - drop linters removed in v2 (deadcode, varcheck, structcheck, gosimple, stylecheck, typecheck, maligned) - gomnd -> mnd (renamed in v2) - move gofmt/goimports under top-level `formatters` - restructure linters-settings -> linters.settings .golangci.yml: relax to preserve v1.50 parity Multi-module verification per AGENTS.md exposed pre-existing issues that v1.50 did not catch. To keep the migration free of business-code changes, add config-level exclusions matching the team's historical style: - errcheck: exclude (*nats.Msg).Ack/AckSync/Nak/NakWithDelay - gocritic: disable appendAssign, hugeParam, sloppyReassign, elseif - lll: raise line-length 140 -> 145 - drop mnd (too noisy on time.Second-style literals) - expand _test.go exclusions: gochecknoinits, unparam, whitespace - per-file: otelbroker/middleware.go (staticcheck, unparam), azuresb/subscription.go (gosec G118), azuresb/receiver.go (misspell) goimports -local "github.com/velmie/broker" applied to 9 files in otelbroker/, azuresb/, idempotency/ — import ordering only, no logic changes. Verification: go test ./... and golangci-lint run ./... green in all 7 modules (., natsjs, otelbroker, sns, sqs, azuresb, idempotency). Real issues hidden behind the new exclusions (azuresb cancel leak, typos, unused tracer values, unchecked Acks) are tracked separately and should be addressed in a follow-up PR after natsjs/v2.7.0 ships.
DereviankoSergey
force-pushed
the
feat/nats-go-v1.52-upgrade
branch
from
6e89e1a to
970436b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.26 is the current stable (released 2026-02).