Skip to content

#1151: Fix error with InterfaceDirRelative for external paths#1157

Open
takanuva15 wants to merge 6 commits into
vektra:v3from
takanuva15:v3
Open

#1151: Fix error with InterfaceDirRelative for external paths#1157
takanuva15 wants to merge 6 commits into
vektra:v3from
takanuva15:v3

Conversation

@takanuva15
Copy link
Copy Markdown

@takanuva15 takanuva15 commented Apr 8, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Go used when building/testing:

  • 1.26

How Has This Been Tested?

  • Unit tests
  • Built the binary locally and tested with my MVE repo

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@takanuva15
Copy link
Copy Markdown
Author

@LandonTClipp This should fix #1151. Feel free to edit the PR as needed to your liking

@LandonTClipp
Copy link
Copy Markdown
Member

@takanuva15 could you give me access to your fork? I am adding an e2e test to verify this behaves properly (which it does!).

@takanuva15
Copy link
Copy Markdown
Author

@takanuva15 could you give me access to your fork? I am adding an e2e test to verify this behaves properly (which it does!).

@LandonTClipp sorry i just saw your message today. You should already have edit permission on this PR, but I added you as a collab on my fork anyways.

image

@takanuva15
Copy link
Copy Markdown
Author

@LandonTClipp Hi, request your review on this PR? You should have full edit access:
image

@LandonTClipp
Copy link
Copy Markdown
Member

LandonTClipp commented May 22, 2026

Sorry for the delay in getting to this, I've been very busy. I tried pushing to your branch but it still gives me permission denied and it seems I didn't accept your invitation soon enough so now it's expired 😓

This diff is really all I want added:

tests.patch

If you can get that integrated then we can merge your PR.

@takanuva15
Copy link
Copy Markdown
Author

@LandonTClipp Sent a new invite. Also applied your patch to this PR. github.com/LandonTClipp/example-go-repo is now showing in the go.mod as indicated in your patch

@LandonTClipp
Copy link
Copy Markdown
Member

We're really close, it just looks like the windows tests are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting "file not found" error for external package interfaces with v3 but not v2

2 participants