#1151: Fix error with InterfaceDirRelative for external paths#1157
#1151: Fix error with InterfaceDirRelative for external paths#1157takanuva15 wants to merge 6 commits into
Conversation
|
@LandonTClipp This should fix #1151. Feel free to edit the PR as needed to your liking |
|
@takanuva15 could you give me access to your fork? I am adding an e2e test to verify this behaves properly (which it does!). |
@LandonTClipp sorry i just saw your message today. You should already have edit permission on this PR, but I added you as a collab on my fork anyways.
|
|
@LandonTClipp Hi, request your review on this PR? You should have full edit access: |
|
Sorry for the delay in getting to this, I've been very busy. I tried pushing to your branch but it still gives me permission denied and it seems I didn't accept your invitation soon enough so now it's expired 😓 This diff is really all I want added: If you can get that integrated then we can merge your PR. |
|
@LandonTClipp Sent a new invite. Also applied your patch to this PR. |
|
We're really close, it just looks like the windows tests are failing. |


Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
Version of Go used when building/testing:
How Has This Been Tested?
Checklist