Skip to content

VF-301 fix: 🐛 hide navbar on desktop#528

Open
phibkro wants to merge 8 commits into
mainfrom
vf-301-fix-desktop-navbar-showing-on-mobile
Open

VF-301 fix: 🐛 hide navbar on desktop#528
phibkro wants to merge 8 commits into
mainfrom
vf-301-fix-desktop-navbar-showing-on-mobile

Conversation

@phibkro

@phibkro phibkro commented Apr 10, 2025

Copy link
Copy Markdown
Member

Describe your changes 📖

Jira ticket: 🔖

VF-XXX

Checklist before requesting a review ✔️

  • I have performed a self-review of my code
  • I have verified that the code works as intended
  • Pipeline runs successfully
  • Sonarcloud scan passes
  • Unit tests passes

@linear

linear Bot commented Apr 10, 2025

Copy link
Copy Markdown

@netlify

netlify Bot commented Apr 10, 2025

Copy link
Copy Markdown

Deploy Preview for vektorprogrammet-homepage ready!

Name Link
🔨 Latest commit e2f493a
🔍 Latest deploy log https://app.netlify.com/sites/vektorprogrammet-homepage/deploys/67f830c169b6db00083dec97
😎 Deploy Preview https://deploy-preview-528--vektorprogrammet-homepage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85
Accessibility: 69
Best Practices: 83
SEO: 86
PWA: 60
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@HeleneSelvig

Copy link
Copy Markdown
Contributor

ser bra ut, litt delay i at navbar fjernes når man går til ny side på mobil

@HeleneSelvig HeleneSelvig self-requested a review April 10, 2025 09:47
HeleneSelvig
HeleneSelvig previously approved these changes Apr 10, 2025
@phibkro

phibkro commented Apr 10, 2025

Copy link
Copy Markdown
Member Author

med useIsMobile() fra shadcn får vi content instantly på mobile nav, men navbaren flickers initially.
med mantine useViewportSize() må vi vente med no content, men navbaren flickerer ikke lenger.
frustrerende

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants