fix: cast hw_version to str for HA device registry compatibility#225
Open
DUC750 wants to merge 1 commit into
Open
fix: cast hw_version to str for HA device registry compatibility#225DUC750 wants to merge 1 commit into
DUC750 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
NilanEntity.device_infopasseshw_versionasint, but the Home Assistant device registry requiresstr. This causes 82 warnings per HA startup on a CTS602 system:Reported in: #224
Root Cause
In
device.py,get_controller_hardware_version()returnsint:In
__init__.py, the value is passed directly to the device registry without casting:Compare
sw_versionwhich already usesget_device_sw_version -> strand works correctly.Fix
One-line change in
custom_components/nilan/__init__.py:Impact
Tested on