docs: add number input to date input example - #4091
Open
SR0725 wants to merge 2 commits into
Open
Conversation
Contributor
|
Thanks for the PR @SR0725 ! Instead of making a new example, I wonder if we can combine this with the recently added example from #4088? Could you add the number input there as well and have it filter the y-axis? Or feel free to come up with a new example that can combine both. We have quite a lot of gallery examples, so it would be nice if related functionality like this can be in the same example. |
Author
|
That makes sense. I folded the number input into interactive_date_input: the date parameter filters the x-axis range, and minimum_visitors filters the y values. I also removed the standalone number-input files. The focused example tests pass 6/6, ruff passes, and the local docs build succeeds. Updated in 10f2e20. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I changed
This covers the number-input example suggested in #3403 without adding another gallery entry.
Testing