Upgrade Polkadot SDK and Frontier to stable2512 by vedhavyas · Pull Request #2 · vedhavyas/subspace

vedhavyas · 2026-03-27T05:43:26Z

Summary

Two-phase Substrate upgrade: stable2503 → stable2506 → stable2512.

Recommend reviewing commit-by-commit.

Commits

844a7dfbb — upgrade polkadot-sdk and frontier to stable2506

Polkadot SDK fork: subspace-v13 (9 commits on stable2506)

8 custom commits cherry-picked from subspace-v12, 1 dropped (already upstream)
Compare: autonomys/polkadot-sdk@3785760...subspace-v13

Breaking changes addressed:

sp-io ABI rework: custom #[runtime_interface] traits updated with explicit wrapper types (PassFatPointerAndDecode, PassPointerAndReadCopy, AllocateAndReturnByCodec)
EnsureInherentsAreFirst → IsInherent in domain executive
RuntimeEvent moved from associated type to trait bound in all Subspace pallets
frame_system::initialize() strict sequential assertion: guarded check_extrinsics_and_do_pre_dispatch
Backend::state_at() gains TrieCacheContext
memory-db 0.32 → 0.34: MemoryDB requires explicit sp_trie::RandomState
API renames: try_sqrt → checked_sqrt, create_inherent → create_bare
Workspace lints: substrate_runtime added to check-cfg

e90bda32b — upgrade polkadot-sdk and frontier to stable2512

Polkadot SDK fork: subspace-v14 (10 commits on stable2512)

9 custom commits cherry-picked from subspace-v13, 1 new (frame-storage-access-test-runtime graceful fallback)
Compare: autonomys/polkadot-sdk@subspace-v13...subspace-v14

Frontier: updated to commit 9d49e36e (compatible with stable2512)

Breaking changes addressed:

Windows CI: -C debuginfo=0 -C link-arg=/DEBUG:NONE for PDB size limits (wasmtime 35)
ForkAware txpool default (addressed in fix commit below)
Host function ABI change for Vec<u8> (addressed in fix commit below)

bd67ddc53 — fix host function ABI compat and default txpool to SingleState

Two fixes found during local dev network upgrade testing with XDM:

ABI fix: The old sp-runtime-interface had a TypeId::of::<u8>() special case — Vec<u8> was passed as raw bytes without SCALE encoding. The new PassFatPointerAndDecode always SCALE-encodes, breaking ABI compatibility with old domain WASM calling verify_mmr_proof. Changed encoded_proof parameter to use PassFatPointerAndRead<Vec<u8>> which preserves the raw-bytes behavior. Only this one parameter was affected — all other host function types verified compatible.
TxPool default: polkadot-sdk stable2512 changed the CLI default for --pool-type to ForkAware. The ForkAware pool crashes when domain subsystem is active (tokio::select! exits when any subtask completes). Reverted the default to SingleState in the fork.

Local dev network test results

Test	Result
Baseline network with XDM channel + transfers	Pass
EVM transactions (transfers + contract deploy)	Pass
Upgrade domain full node sync (XDM blocks)	Pass — domain hashes match
Consensus binary swap (baseline → upgrade)	Pass
Consensus runtime upgrade	All nodes survive
Domain runtime upgrade	All nodes survive
Post-upgrade XDM + EVM transactions	Pass

Code contributor checklist:

I have read, understood and followed contributing guide

vedhavyas

not sure why workspace lints are introduced. Unnecessary move of same code from one line to another

vedhavyas · 2026-03-27T05:47:27Z

 runtime-benchmarks = []
+
+# @claude why is this required?
+[lints]


vedhavyas · 2026-03-27T05:47:35Z


 runtime-benchmarks = []
+
+# @claude why is this required?


remove comment

vedhavyas · 2026-03-27T05:48:41Z

-        domain_runtime_code: Vec<u8>,
-        bundle_body: Vec<OpaqueExtrinsic>,
-    ) -> Option<H256> {
+        domain_runtime_code: PassFatPointerAndDecode<Vec<u8>>,


can you drop the PR that introduced this change upstream ?

vedhavyas · 2026-03-27T05:51:29Z

-    let state = alice.backend.state_at(best_hash).expect("Get state");
+    let state = alice
+        .backend
+        .state_at(best_hash, sc_client_api::TrieCacheContext::Trusted)


ensure Trusted is waht we need for all the places we use the state_at

vedhavyas · 2026-03-27T05:52:05Z

            "Parent hash should be valid.",
        );

-        match ExecutiveConfig::ensure_inherents_are_first(block) {


ensure_inherents_are_first

is this removed upstream ?

vedhavyas · 2026-03-27T05:55:23Z

 impl frame_system::Config for Runtime {
-    /// The ubiquitous event type.
    type RuntimeEvent = RuntimeEvent;
+    /// The ubiquitous event type.


dont understand this change

vedhavyas · 2026-03-27T05:55:43Z

 }

 impl pallet_balances::Config for Runtime {
+    type RuntimeEvent = RuntimeEvent;


dont understand this one too

Polkadot SDK fork: subspace-v13 (8 custom commits on stable2506) Frontier: upstream stable2506 (b70f725a8) Breaking changes addressed: - sp-io ABI: replace PassBy/Codec with explicit wrapper types (PassFatPointerAndDecode, PassPointerAndReadCopy, AllocateAndReturnByCodec) - EnsureInherentsAreFirst removed: domain executive aligned with upstream frame_executive structure (inline inherent check in apply_extrinsics) - RuntimeEvent removed from pallet configs (moved to trait bound) - frame_system::initialize() strict sequential block numbers: guard check_extrinsics_and_do_pre_dispatch, fix test and benchmark helpers - Backend::state_at() gains TrieCacheContext parameter - memory-db 0.32 -> 0.34 with explicit sp_trie::RandomState for WASM - NetworkConfiguration gains min_peers_to_start_warp_sync - sc_service::Configuration gains warm_up_trie_cache - StorageCmd::run gains trie_cache parameter - try_sqrt -> checked_sqrt, create_inherent -> create_bare - workspace lints for substrate_runtime cfg (set by wasm-builder) - skip frame-storage-access-test-runtime wasm build in benchmarks (upstream bug: with_current_project() fails outside polkadot-sdk workspace)

vedhavyas · 2026-03-27T06:37:49Z

                        let storage = backend.expose_storage();

-                        cmd.run(config, client, db, storage)
+                        cmd.run(config, client, db, storage, None)


whats is NONE here ?

vedhavyas · 2026-03-27T06:40:57Z

+
+[[package]]
+name = "darling_macro"
+version = "0.21.3"


two versions of darling_macro ?

vedhavyas · 2026-03-27T14:23:16Z

 pub struct OnChargeTransaction;

+impl pallet_transaction_payment::TxCreditHold<Runtime> for OnChargeTransaction {
+    type Credit = ();


whats this ?

vedhavyas · 2026-03-27T14:23:48Z

        telemetry: telemetry.as_mut(),
        tx_handler_controller,
        sync_service: sync_service.clone(),
+        tracing_execute_block: None,


whats this >

vedhavyas · 2026-03-27T14:24:25Z

                filter_pool,
                500_usize, // max stored filters
                max_past_logs,
+                10_000_u32, // max block range for eth_getLogs


whats this ?

vedhavyas · 2026-03-27T14:26:13Z

    PrecompileAt<AddressU64<5>, Modexp, EthereumPrecompilesChecks>,
    // Non-Frontier specific nor Ethereum precompiles :
-    PrecompileAt<AddressU64<1024>, Sha3FIPS256, (CallableByContract, CallableByPrecompile)>,
+    PrecompileAt<AddressU64<1024>, Sha3FIPS256<R, ()>, (CallableByContract, CallableByPrecompile)>,


whats this ?

vedhavyas · 2026-03-27T14:27:22Z

-                &block_hash,
-                &Default::default(),
-            );
+            // Only initialize if not already at the expected block number,


can you point me where in the Executive change happened that broke this change

vedhavyas · 2026-03-27T14:28:52Z

+            _prev_block_number: BlockNumber,
+            _best_known_block_number: Option<BlockNumber>,
+        ) -> Result<mmr::AncestryProof<mmr::Hash>, mmr::Error> {
+            Err(mmr::Error::GenerateProof)


why is this not implemented?

vedhavyas commented Mar 27, 2026

View reviewed changes

vedhavyas force-pushed the feature/substrate-upgrade-2506 branch 3 times, most recently from 2eb73fb to 58f8400 Compare March 27, 2026 14:19

vedhavyas commented Mar 27, 2026

View reviewed changes

vedhavyas force-pushed the feature/substrate-upgrade-2506 branch 7 times, most recently from 578cfc6 to 89d297e Compare March 28, 2026 22:10

upgrade polkadot-sdk and frontier to stable2512

10db821

vedhavyas force-pushed the feature/substrate-upgrade-2506 branch from 89d297e to 10db821 Compare March 28, 2026 23:09

vedhavyas changed the title ~~Upgrade Polkadot SDK to stable2506~~ Upgrade Polkadot SDK and Frontier to stable2512 Mar 31, 2026

Conversation

vedhavyas commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Commits

Local dev network test results

Code contributor checklist:

Uh oh!

vedhavyas left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vedhavyas commented Mar 27, 2026 •

edited

Loading