fix(ci): align config field count and CLI consolidation call with #1746#1757
Merged
Conversation
PR #1746 added enable_auto_consolidation to _CONFIGURABLE_FIELDS and introduced a ConsolidationRequest body on the /consolidate endpoint, but didn't update test_hierarchical_fields_categorization (still expects 35 fields) or the CLI's trigger_consolidation wrapper (still calls the generated client with 2 args), so CI on this branch breaks on test-api, test-rust-cli, test-embed-windows, and test-doc-examples (cli). Bump the expected count to 36, add enable_auto_consolidation to the explicit assertions, and pass a default ConsolidationRequest to the generated client so the no-scope CLI invocation keeps consolidating all unconsolidated memories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat(api): add targeted consolidation by observation scopes) addedenable_auto_consolidationto_CONFIGURABLE_FIELDSbut didn't updatetest_hierarchical_fields_categorization(still asserted 35 — now passes with 36 + an explicit assertion for the new field).ConsolidationRequestbody toPOST /v1/default/banks/{bank_id}/consolidatebut didn't update the CLI wrapper athindsight-cli/src/api.rs:956, which still called the generated client with two args. The third positional arg is now&ConsolidationRequest::default(), which hasobservation_scopes: Noneand keeps the no-scope CLI invocation processing all unconsolidated memories (the documented behavior when the body is omitted).test-api,test-rust-cli,test-embed-windows, andtest-doc-examples (cli)for exactly these two reasons.Test plan
uv run pytest tests/test_hierarchical_config.py::test_hierarchical_fields_categorization— passes locallycargo buildinhindsight-cli/— clean./scripts/hooks/lint.sh— cleantest-api,test-rust-cli,test-embed-windows,test-doc-examples (cli)(waiting for the active GitHub Actions incident at https://stspg.io/6gzfzr1dx684 to clear)