Skip to content

third-party: update fmt to 12.1.0#319

Closed
VDanielEdwards wants to merge 3 commits intomainfrom
dev/third-party/fmt/update-to-12-1-0
Closed

third-party: update fmt to 12.1.0#319
VDanielEdwards wants to merge 3 commits intomainfrom
dev/third-party/fmt/update-to-12-1-0

Conversation

@VDanielEdwards
Copy link
Copy Markdown
Member

Subject

Updates fmt to version 12.1.0 which fixes a warning emitted on modern GCC versions (which triggers an error due to our warning flags).

Developer checklist (address before review)

  • Changelog.md updated
  • Prepared update for depending repositories
  • Documentation updated (public API changes only)
  • API docstrings updated (public API changes only)
  • Rebase → commit history clean
  • Squash and merge → proper PR title

Signed-off-by: Daniel Edwards <Daniel.Edwards@vector.com>
Signed-off-by: Daniel Edwards <Daniel.Edwards@vector.com>
@VDanielEdwards VDanielEdwards self-assigned this May 5, 2026
@VDanielEdwards VDanielEdwards added the needs reviewer This issue is looking for a reviewer. label May 5, 2026
Copy link
Copy Markdown
Contributor

@VLukasBecker VLukasBecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Signed-off-by: Daniel Edwards <Daniel.Edwards@vector.com>
@VDanielEdwards VDanielEdwards force-pushed the dev/third-party/fmt/update-to-12-1-0 branch from 049608a to 72d4823 Compare May 5, 2026 08:53
@VDanielEdwards VDanielEdwards removed the needs reviewer This issue is looking for a reviewer. label May 5, 2026
@VDanielEdwards
Copy link
Copy Markdown
Member Author

After some investigation, it seems that version 12.0.0 and 12.1.0 of fmt have more issues with warnings on MSVC (tried building with a recent MSVC version for 32-bit). I'm closing this PR, and we'll try again after upstream has stabilized a bit more.

I'll adjust and streamline the overall warning settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants