Skip to content

fix(k8s): correct helm/benchmark operator manifest output paths in make targets#3564

Closed
takuyaymd wants to merge 1 commit into
feature/vald-operator/initial-developmentfrom
fix/vald-operator/helm-deploy-path
Closed

fix(k8s): correct helm/benchmark operator manifest output paths in make targets#3564
takuyaymd wants to merge 1 commit into
feature/vald-operator/initial-developmentfrom
fix/vald-operator/helm-deploy-path

Conversation

@takuyaymd

Copy link
Copy Markdown
Contributor

Description

helm template --output-dir $(TEMP_DIR) renders manifests under a directory named after the chart (vald-helm-operator / vald-benchmark-operator), but the k8s/operator/helm/* and k8s/operator/benchmark/* make targets referenced $(TEMP_DIR)/operator/helm/... and $(TEMP_DIR)/operator/benchmark/..., which never exist.

As a result those targets failed immediately with:

error: the path ".../operator/helm/crds/valdrelease.yaml" does not exist

so make k8s/operator/helm/deploy (and the delete / update and the benchmark-operator equivalents) could not deploy or render the operators at all.

What changed: point the paths to the chart-name directories (vald-helm-operator / vald-benchmark-operator) across the affected targets:

  • k8s/operator/helm/{deploy,delete,update}
  • k8s/operator/benchmark/{deploy,delete,update}

Why: this is purely a path mismatch introduced when the render layout changed to helm template --output-dir. The k8s/operator/vald/update target was already using the correct vald-operator directory, which confirms the intended pattern.

Verification: on a local k3d cluster, after the fix make k8s/operator/helm/deletemake k8s/operator/helm/deploy runs end-to-end (CRDs created, vald-helm-operator pods reach Ready).

Related Issue

N/A — found while manually verifying the vald-operator deploy flow locally (kind/k3d). Happy to open a tracking issue if preferred.

Versions

  • Vald Version: v1.7.17
  • Go Version: v1.26.1
  • Rust Version: v1.94.1
  • Docker Version: v29.3.1
  • Kubernetes Version: v1.35.3
  • Helm Version: v4.1.3
  • NGT Version: v2.7.2
  • Faiss Version: v1.14.1

Checklist

Special notes for your reviewer

  • Scope is intentionally limited to the make-target output-path fix. It does not touch operator behavior.
  • Note: make e2e/v2/actions/run/operator deploys only vald-operator (no vald-helm-operator) and verifies ValdRelease generation, so this broken path was not exercised by CI — it surfaces when deploying vald-helm-operator / benchmark-operator via make. The fix was verified manually on k3d.
  • A separate topic found during the same verification — how vald-operator should handle multiple clusters[] entries on a single cluster (the multi-cluster sample / distribution question) — is intentionally not part of this PR and is being discussed separately.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 43ec24d4-c525-4636-b9a7-d277b21c72d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/vald-operator/helm-deploy-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vdaas-ci

Copy link
Copy Markdown
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@takuyaymd

Copy link
Copy Markdown
Contributor Author

Resolved in #3560

@takuyaymd takuyaymd closed this Jul 16, 2026
@takuyaymd takuyaymd deleted the fix/vald-operator/helm-deploy-path branch July 16, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants