fix(k8s): correct helm/benchmark operator manifest output paths in make targets#3564
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[CHATOPS:HELP] ChatOps commands.
|
|
Resolved in #3560 |
Description
helm template --output-dir $(TEMP_DIR)renders manifests under a directory named after the chart (vald-helm-operator/vald-benchmark-operator), but thek8s/operator/helm/*andk8s/operator/benchmark/*make targets referenced$(TEMP_DIR)/operator/helm/...and$(TEMP_DIR)/operator/benchmark/..., which never exist.As a result those targets failed immediately with:
so
make k8s/operator/helm/deploy(and thedelete/updateand the benchmark-operator equivalents) could not deploy or render the operators at all.What changed: point the paths to the chart-name directories (
vald-helm-operator/vald-benchmark-operator) across the affected targets:k8s/operator/helm/{deploy,delete,update}k8s/operator/benchmark/{deploy,delete,update}Why: this is purely a path mismatch introduced when the render layout changed to
helm template --output-dir. Thek8s/operator/vald/updatetarget was already using the correctvald-operatordirectory, which confirms the intended pattern.Verification: on a local k3d cluster, after the fix
make k8s/operator/helm/delete→make k8s/operator/helm/deployruns end-to-end (CRDs created,vald-helm-operatorpods reach Ready).Related Issue
N/A — found while manually verifying the vald-operator deploy flow locally (kind/k3d). Happy to open a tracking issue if preferred.
Versions
Checklist
Special notes for your reviewer
make e2e/v2/actions/run/operatordeploys only vald-operator (no vald-helm-operator) and verifies ValdRelease generation, so this broken path was not exercised by CI — it surfaces when deploying vald-helm-operator / benchmark-operator via make. The fix was verified manually on k3d.clusters[]entries on a single cluster (the multi-cluster sample / distribution question) — is intentionally not part of this PR and is being discussed separately.