Skip to content

Add ORCA implementation based on stats API#3541

Open
Matts966 wants to merge 2 commits into
feature/gateway/add-resource-stats-detailfrom
feature/gateway/orca
Open

Add ORCA implementation based on stats API#3541
Matts966 wants to merge 2 commits into
feature/gateway/add-resource-stats-detailfrom
feature/gateway/orca

Conversation

@Matts966

@Matts966 Matts966 commented Jul 1, 2026

Copy link
Copy Markdown
Member

Description

READ

WRITE

Related Issue

Versions

  • Vald Version: v1.7.17
  • Go Version: v1.26.1
  • Rust Version: v1.94.1
  • Docker Version: v29.3.1
  • Kubernetes Version: v1.35.3
  • Helm Version: v4.1.3
  • NGT Version: v2.7.2
  • Faiss Version: v1.14.1

Checklist

Special notes for your reviewer

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 1, 2026

Copy link
Copy Markdown

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: 76c99bc
Status: ✅  Deploy successful!
Preview URL: https://ae0e76d8.vald.pages.dev
Branch Preview URL: https://feature-gateway-orca.vald.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3e11aa29-bb90-4add-ac66-b768acb02d01

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/gateway/orca

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vdaas-ci

vdaas-ci commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

[WARNING:INTCFG] Changes in internal/config may require you to change Helm charts. Please check.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 32.91925% with 108 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.26%. Comparing base (5e042b9) to head (76c99bc).

Files with missing lines Patch % Lines
pkg/gateway/lb/service/orca.go 45.71% 55 Missing and 2 partials ⚠️
pkg/gateway/lb/service/gateway.go 0.00% 24 Missing ⚠️
pkg/gateway/lb/service/option.go 0.00% 16 Missing ⚠️
pkg/gateway/lb/usecase/vald.go 0.00% 6 Missing ⚠️
pkg/gateway/lb/handler/grpc/object.go 0.00% 4 Missing ⚠️
pkg/gateway/lb/handler/grpc/aggregation.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                              Coverage Diff                              @@
##           feature/gateway/add-resource-stats-detail    #3541      +/-   ##
=============================================================================
- Coverage                                      26.98%   26.26%   -0.73%     
=============================================================================
  Files                                            530      575      +45     
  Lines                                          49217    50779    +1562     
=============================================================================
+ Hits                                           13281    13336      +55     
- Misses                                         34955    36460    +1505     
- Partials                                         981      983       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants