Feature/esteiras GitHub actions#98
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| name: Push Image DockerHub | ||
| runs-on: ubuntu-latest | ||
| needs: [lint-styles, tests] | ||
| if: github.event_name == 'pull_request' && github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'develop' |
There was a problem hiding this comment.
Em que momento essa condição será verdadeira?
Analisando o tipo de trigger configurado:
pull_request:
types: [opened, reopened, synchronize]
branches:
- develop
Me parece que a lógica está inconsistente.
considerar adicionar o closed na trigger. [opened, reopened, synchronize, closed]
| @@ -1,44 +0,0 @@ | |||
| name: msSimulado | |||
There was a problem hiding this comment.
Porque estamos removendo a pipeline do main, essa alteração está considerando eventuais fluxos de hotfix? ou verificações de segurança em releases complexas?
Além disso como serão gerenciadas as tags para o main?.
|
Qual problema estamos resolvendo com esse PR exatamente? senti falta de uma documentação de referência para entender o propósito dessas alterações, adicionar assim que possível. |
3 participants
No description provided.