feat: cwriter for wasm v7 - #133
Open
Icemap wants to merge 1 commit into
Open
Conversation
|
Your commits does not support GOOS=wasip1 and GOARCH=wasm |
Solaris-star
left a comment
Contributor
There was a problem hiding this comment.
This is a superset of #132 — it adds the same WASM stubs plus util_wasm.go for the ioctl constant. Two issues:
-
Build tags: uses the old
//+buildsyntax. Go 1.17+ prefers//go:build. #132 already has the correct syntax — worth aligning. -
IsTerminalreturnstrue: same concern as #132 — WASM has no terminal, sofalseis more accurate. Callers checkingIsTerminalto decide between TTY and plain output would get the wrong branch.
Recommend consolidating #132 and #133 into a single PR with //go:build tags and IsTerminal → false. The core approach (dummy Writer, no-op GetSize) is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.