Add application.js if missing#273
Open
jlugner wants to merge 1 commit into
Open
Conversation
Author
|
Failing build seems to be Capybara not playing well with the recent release of Puma 6.0. Fixed on Capybara#master, so probably overkill to lock the version here. New version should be out soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #252 rails 6+ doesn't generate the required javascript entry point for godmins install_generator. Below approach is likely an overly naive solution but should do the trick for projects running rails 6+. I've done some basic testing for both the Engine installation and standalone installations for latest versions of rails 6 and 7, and it seems to work.