Skip to content

ci: run browser jobs in official Playwright container #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rqbazan merged 1 commit into from
May 27, 2026
Merged

ci: run browser jobs in official Playwright container #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ concurrency:
jobs:
test:
runs-on: blacksmith-4vcpu-ubuntu-2404
# Run inside the official Playwright image: browsers (chromium v1217 for
# playwright 1.59.1) are pre-baked, so the lib browser tests need no
# `playwright install` download — which hangs after 100% on these runners.
container: mcr.microsoft.com/playwright:v1.59.1-noble
timeout-minutes: 15
env:
MISE_EXPERIMENTAL: "1"
steps:
Expand All @@ -35,9 +40,6 @@ jobs:
- name: 💅 Check (biome + tsc)
run: mise run check

- name: 🎭 Install Playwright browser (lib browser tests)
run: mise run playwright:install

- name: 🧪 Test unit (lib)
run: mise run lib:test

Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ jobs:
test:
name: ${{ matrix.example }}
runs-on: blacksmith-4vcpu-ubuntu-2404
# Browser examples run inside the official Playwright image (browsers
# pre-baked, no download); non-browser examples run on the bare runner so
# their bun/deno toolchains stay untouched. Empty string ⇒ no container.
container: ${{ matrix.browser && 'mcr.microsoft.com/playwright:v1.59.1-noble' || '' }}
timeout-minutes: 12
env:
MISE_EXPERIMENTAL: "1"
concurrency:
Expand Down Expand Up @@ -63,9 +68,5 @@ jobs:
- name: 🎁 Pack @vlandoss/env
run: mise run env:pack

- name: 🎭 Install Playwright browsers
if: matrix.browser
run: mise run playwright:install

- name: 🧩 Test e2e
run: mise run //examples/${{ matrix.example }}:test:e2e
Loading