[#295]:svarga:build, honor CMP0074 so examples find_package respects HDF5_ROOT#296
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #295.
Problem
A CMake dev warning at configure (surfaced by the
BUILD_EXAMPLES=ONdefault, #278):examples/CMakeLists.txtdeclarescmake_minimum_required(VERSION 3.10), which predates CMP0074 (3.12). Under that baseline the policy defaults to OLD, sofind_package(HDF5)ignores theHDF5_ROOTthe file builds (lines 20-25) for custom HDF Group installs — the discovery logic was silently inert.Fix
cmake_policy(SET CMP0074 NEW)afterproject()(guarded withif(POLICY ...)).Verification
Configure with
HDF5_ROOTset: 0 CMP0074 warnings, 0 CMake warnings, HDF5 found, no "ignoring the variable" message.