Skip to content

[#289]:svarga:fix, H5CPP_supported_elementary_types redefined with conflicting values (~50 build warnings) #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steven-varga merged 1 commit into from
May 30, 2026
+6 −2
Merged

[#289]:svarga:fix, H5CPP_supported_elementary_types redefined with conflicting values (~50 build warnings) #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions h5cpp/H5Tmeta.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,12 @@
#include <cstring>
#include <utility>

//FIXME: move it elsewhere
#define H5CPP_supported_elementary_types "supported elementary types ::= pod_struct | float | double | [signed](int8 | int16 | int32 | int64)"
// H5CPP_supported_elementary_types is defined once in H5misc.hpp (the
// canonical copy that includes `enum`); H5misc is always pulled in ahead of
// this header via h5cpp/core, and the macro is only consumed by the
// static_assert diagnostics in H5Dread/H5Dwrite. The duplicate definition
// that used to live here conflicted with H5misc's and produced a redefinition
// warning in every TU including core (#289).

// stl detection with templates, this probably should stay until concepts become mainstream
namespace h5::meta {
Expand Down
Loading