Skip to content

Fix mobile nav links not navigating #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vanvixi merged 1 commit into from
Jun 21, 2026
Merged

Fix mobile nav links not navigating #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions website/lib/layout/mobile_nav.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'package:jaspr/dom.dart';
import 'package:jaspr/jaspr.dart';
import 'package:universal_web/web.dart' as web;

import '../data/site_data.dart';

Expand All @@ -18,6 +19,23 @@ class _MobileNavState extends State<MobileNav> {
void _toggle() => setState(() => _open = !_open);
void _close() => setState(() => _open = false);

// Drive navigation ourselves and then close. Closing re-renders and detaches
// the link, which cancels the anchor's default click before it navigates, so
// a plain `onClick: _close` closed the menu but never jumped to the section.
Map<String, EventCallback> _navTo(String href) => {
'click': (event) {
event.preventDefault();
if (kIsWeb) {
if (href.startsWith('#')) {
web.window.location.hash = href;
} else {
web.window.open(href, '_blank');
}
}
_close();
},
};

@override
Component build(BuildContext context) {
return div(classes: 'relative md:hidden', [
Expand Down Expand Up @@ -48,7 +66,7 @@ class _MobileNavState extends State<MobileNav> {
classes:
'block rounded-xl px-3 py-2 text-sm font-medium text-ink '
'transition-colors hover:bg-raised',
onClick: _close,
events: _navTo(item.href),
[.text(item.label)],
),
div(classes: 'my-1 h-px bg-line', const []),
Expand All @@ -59,15 +77,15 @@ class _MobileNavState extends State<MobileNav> {
classes:
'block rounded-xl px-3 py-2 text-sm font-medium text-muted '
'transition-colors hover:bg-raised',
onClick: _close,
events: _navTo(SiteLinks.github),
[.text('GitHub ↗')],
),
a(
href: SiteLinks.docs,
classes:
'block rounded-xl px-3 py-2 text-sm font-medium text-muted '
'transition-colors hover:bg-raised',
onClick: _close,
events: _navTo(SiteLinks.docs),
[.text('Docs')],
),
],
Expand Down
Loading