Skip to content

feat: support event tracing#607

Open
hwjiangkai wants to merge 5 commits into
mainfrom
tracing
Open

feat: support event tracing#607
hwjiangkai wants to merge 5 commits into
mainfrom
tracing

Conversation

@hwjiangkai

@hwjiangkai hwjiangkai commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

support event tracing

enable related configurations in the gateway and trigger:

    observability:
      tracing:
        enable: false
        # OpenTelemetry Collector endpoint, https://opentelemetry.io/docs/collector/getting-started/
        otel_collector: http://127.0.0.1:4318
        event_tracing_enable: true
        # Vanus Controller endpoints
        event_collector: 
          - vanus-controller-0.vanus-controller.trace.svc.cluster.local:8080
          - vanus-controller-1.vanus-controller.trace.svc.cluster.local:8080
        eventbus: event-tracing

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@hwjiangkai hwjiangkai force-pushed the tracing branch 3 times, most recently from 2e186d2 to ae03329 Compare July 12, 2023 12:52
@codecov

codecov Bot commented Jul 12, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.52632% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.07%. Comparing base (ee76217) to head (daa31f6).
⚠️ Report is 108 commits behind head on main.

Files with missing lines Patch % Lines
internal/gateway/gateway.go 55.00% 18 Missing ⚠️
internal/trigger/trigger/trigger.go 47.36% 10 Missing ⚠️
internal/gateway/proxy/proxy.go 0.00% 9 Missing ⚠️
internal/trigger/reader/reader.go 65.38% 8 Missing and 1 partial ⚠️
internal/gateway/proxy/deadletter.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   57.07%   54.07%   -3.00%     
==========================================
  Files         190      224      +34     
  Lines       15191    18125    +2934     
==========================================
+ Hits         8670     9801    +1131     
- Misses       5884     7534    +1650     
- Partials      637      790     +153     
Files with missing lines Coverage Δ
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/gateway/proxy/proxy.go 22.94% <0.00%> (-0.15%) ⬇️
internal/trigger/reader/reader.go 75.15% <65.38%> (-0.03%) ⬇️
internal/trigger/trigger/trigger.go 64.70% <47.36%> (-2.04%) ⬇️
internal/gateway/gateway.go 55.26% <55.00%> (-12.41%) ⬇️

... and 85 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 895dd83...daa31f6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hwjiangkai hwjiangkai force-pushed the tracing branch 2 times, most recently from 920eaf7 to 2e0ef9d Compare July 13, 2023 02:54
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
@hwjiangkai hwjiangkai force-pushed the tracing branch 5 times, most recently from 58b04d8 to af954f9 Compare July 17, 2023 11:42
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant