util: replace deprecated reflect.StringHeader/SliceHeader#121
Open
c-tonneslan wants to merge 1 commit into
Open
util: replace deprecated reflect.StringHeader/SliceHeader#121c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
reflect.StringHeader and reflect.SliceHeader are deprecated since Go 1.20 in favour of unsafe.StringData/SliceData/String/Slice. Same swap that landed in fasthttp (#1481). s2b becomes a one-liner, b2s also moves off the dodgy *(*string)(unsafe.Pointer(&b)) trick onto unsafe.String, which is the documented spelling for this conversion. Behaviour is unchanged. Closes valyala#99 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99.
reflect.StringHeader and reflect.SliceHeader were deprecated in Go 1.20 in favour of the unsafe.String / unsafe.Slice / unsafe.StringData / unsafe.SliceData family. Same swap that landed in fasthttp via #1481.
While I was in there I also moved b2s off the older `*(*string)(unsafe.Pointer(&b))` form onto `unsafe.String`, which is the documented spelling for this conversion. Behaviour is unchanged and tests pass.