Making PR's run unstable and latest only, adding a daily job for all versions - #117
Conversation
…versions Signed-off-by: Cameron Zack <zackcam@amazon.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughCI now discovers Valkey versions dynamically for scheduled, manual, push, and pull request runs. Release and test jobs consume the generated matrix. ChangesDynamic version CI
Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant GetVersions
participant ValkeyGit
participant CIJobs
participant build_sh
GitHubActions->>GetVersions: Start workflow and select event-specific versions
GetVersions->>ValkeyGit: Query supported version branches
ValkeyGit-->>GetVersions: Return remote refs
GetVersions-->>CIJobs: Provide JSON server_version matrix
CIJobs->>build_sh: Run with SERVER_VERSION
build_sh->>ValkeyGit: Fetch supported version refs
ValkeyGit-->>build_sh: Return valid versions
build_sh-->>CIJobs: Continue or reject unsupported version
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 23-35: Make Valkey version discovery fail explicitly in both
.github/workflows/ci.yml lines 23-35 and build.sh lines 84-90: enable pipefail,
check the git ls-remote discovery pipeline result, and reject an empty
numeric-version list before constructing the JSON or VALID_VERSIONS. Preserve
the existing unstable/latest selection behavior only after successful non-empty
discovery.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6f99ef27-17f0-458c-9b07-d5675dcd5be1
📒 Files selected for processing (2)
.github/workflows/ci.ymlbuild.sh
| # All versions run at 06:00 UTC every day (full backwards-compat matrix). | ||
| schedule: | ||
| - cron: '0 6 * * *' |
There was a problem hiding this comment.
This is a good addition, would work like daily/weekly in valkey
| echo "Valid versions are: $(printf '%s\n' "$VALID_VERSIONS" | sort -V | tr '\n' ' ')" | ||
| exit 1 | ||
| fi | ||
|
|
There was a problem hiding this comment.
On another thought this will break the offline build. might want to add a condition for when this is called
There was a problem hiding this comment.
Just fixed, made it so we log but continue. We will still fail if no binary is there but that was the case before
Signed-off-by: Cameron Zack <zackcam@amazon.com>
2 participants
This pr has set up a daily job to run JSON against all versions of valkey (If this becomes unwieldily we can easily amend to limit number of versions). In addition it now will run pr requests only against unstable and the latest version which is got dynamically so will not need to be updated on releases. The build script also now contains a dynamic way of checking and asserting what versions are availble