added a ci check for version bump - #207
Open
Bloodraven21 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ishan Jain <ishanij10115@gmail.com>
Collaborator
Author
Bloodraven21
added
the
chart:valkey-operator
daanvinken
reviewed
Jun 29, 2026
| set -euo pipefail | ||
|
|
||
| BASE="origin/${GITHUB_BASE_REF:-main}" | ||
| git fetch --no-tags --depth=1 origin "${GITHUB_BASE_REF:-main}" |
Contributor
There was a problem hiding this comment.
nit: Depth is already set to 0 on the top, may be redundant
| git fetch --no-tags --depth=1 origin "${GITHUB_BASE_REF:-main}" | ||
|
|
||
| # Did any chart template (or the chart metadata) change vs the base branch? | ||
| if git diff --quiet "$BASE"...HEAD -- valkey-operator/templates valkey-operator/crds; then |
Contributor
There was a problem hiding this comment.
May want to check for values.yaml or Chart.yaml as well, e.g. if we update default values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CI check to enforce chart version bump on template changes
What
Adds a new chart-version job to .github/workflows/test-operator.yml that fails the build when valkey-operator template files are modified without bumping the
chart version in Chart.yaml.
Why
It is easy to change a chart's templates and forget to bump the chart version. Shipping template changes under an unchanged version means consumers can pull a
different chart for the same version, which breaks reproducibility and caching. This check makes the version bump a required, automated gate.
How it works
skipped.
GitHub annotation: "please bump the chart version".
Examples