added support for network policies its a breaking change - #185
Open
Bloodraven21 wants to merge 2 commits into
Open
added support for network policies its a breaking change#185Bloodraven21 wants to merge 2 commits into
Bloodraven21 wants to merge 2 commits into
Conversation
Signed-off-by: Ishan Jain <ishanij10115@gmail.com>
Collaborator
Author
|
issue |
Signed-off-by: Ishan Jain <ishanij10115@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds opinionated NetworkPolicy support to the valkey chart, adapted from the Bitnami Redis chart pattern referenced in the issue. Previously networkPolicy was a bare free-form passthrough (networkPolicy: {}) requiring users to hand-write complete K8s
ingress/egress rules. This replaces it with a structured, documented config that handles the common cases out of the box while still allowing arbitrary extra rules.
What it does
When networkPolicy.enabled: true, the chart renders a NetworkPolicy that:
Disabled by default — no behavior change unless opted in.