feat: add namespaceOverride support - #177
Open
guimoreirar wants to merge 2 commits into
Open
Conversation
Signed-off-by: Guilherme Moreira Rodrigues <gui.rodrigues@lerian.studio>
Author
Collaborator
|
Hi @guimoreirar, thank you for the PR and sorry for the delay on the review. It looks good! It is just missing one resource, and test case, at least for the main resources like Deployment and StatefulSet. Ideally it would render entire chart and confirm all resources are scoped to the right namespace. |
sgissi
reviewed
Jun 19, 2026
Signed-off-by: Guilherme Moreira Rodrigues <gui.rodrigues@lerian.studio>
Author
|
@sgissi Can you review this PR again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add namespaceOverride value (empty by default) and valkey.namespace helper to allow deploying resources into a different namespace when used as a subchart in umbrella charts. No breaking change for existing users.