feat: support Valkey Cluster under various common conditions - #175
Closed
ankitpatisfdc wants to merge 26 commits into
Closed
feat: support Valkey Cluster under various common conditions#175ankitpatisfdc wants to merge 26 commits into
ankitpatisfdc wants to merge 26 commits into
Conversation
ankitpatisfdc
force-pushed
the
feature/valkey-cluster-mode-next
branch
from
May 24, 2026 09:30
e45ca4e to
598a082
Compare
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
ankitpatisfdc
force-pushed
the
feature/valkey-cluster-mode-next
branch
from
July 12, 2026 17:40
598a082 to
e4c7f7e
Compare
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Signed-off-by: Ankit Pati <ankit.pati@salesforce.com>
Collaborator
|
hey sorry but the valkey cluster would be only supported by the valkey resources helm chart |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by the feedback on my earlier PR, this PR introduces a functional test suite using
kind, and uses it to iterate on multiple features with LLM agents using logs fromkinddeployments as feedback.This is a separate PR because
valkey-helmisn’t clear from existing literature within the repository, andFrom recent commits to
main, it’s clear the maintainers have decided on an operator instead of a Helm chart for cluster support. However, as of now, there is still value in having fleshed-out and tested cluster capability within the chart.Please note that the contributions are LLM-assisted, but thoroughly tested through unit tests, functional tests, and actual production deployments to GKE.
YMMV on other providers, but I remain committed to supporting the major cloud and K8s providers and their quirks, if any are brought to my attention.