docs(python): add mTLS examples to TLS page - #304
Open
Aryex wants to merge 1 commit into
Open
Conversation
Signed-off-by: kiro-agent <kiro-agent@users.noreply.github.com>
Aryex
added
documentation
Aryex
marked this pull request as ready for review
July 30, 2026 22:09
jeremyprime
requested review from
jeremyprime and
xShinnRyuu
and removed request for
jeremyprime
July 30, 2026 22:22
jeremyprime
reviewed
Jul 30, 2026
| * **Path vs bytes are exclusive:** do not mix modes on the same builder. | ||
| In Go, calling both `WithMutualTLS` and `WithMutualTLSFromFiles` on the same `TlsConfiguration` will replace the previous setting (the last call wins). | ||
| To switch modes, create a new `TlsConfiguration`. | ||
| In Python, passing both path-based (`client_cert_path`/`client_key_path`) and bytes-based (`client_cert_pem`/`client_key_pem`) parameters raises a `ConfigurationError` at construction time. |
Collaborator
There was a problem hiding this comment.
I think both this and the other point below are no longer at construction time, instead at connection time now.
currantw
removed their request for review
July 31, 2026 03:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Python code examples for all four mTLS subsections on the Configure TLS page, replacing the "Coming soon" placeholders.
Source Commits
ba1ad81— feat(python): add automatic mTLS client certificate/key reload (#6596)Changes
client_cert_pem/client_key_pemclient_cert_path/client_key_pathcert_reload_interval_secondsload_client_certificate_and_key_from_filehelperContext
Python mTLS support (both byte-based and path-based with automatic reload) shipped in valkey-glide #6596. This extends the same feature previously landed for Java (#6386) and Go (#6384). The existing doc PR #271 covers Java only and is authored from a fork; this PR adds the Python examples independently.
cc @xShinnRyuu
This PR was generated by the automated documentation pipeline.