Skip to content

dev(clean): Fix labels, add address_resolver clarification, xUnit1051 - #489

Merged
currantw merged 12 commits into
valkey-io:mainfrom
currantw:currantw/assorted-cleanup
Jul 31, 2026
Merged

dev(clean): Fix labels, add address_resolver clarification, xUnit1051#489
currantw merged 12 commits into
valkey-io:mainfrom
currantw:currantw/assorted-cleanup

Conversation

@currantw

@currantw currantw commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

A few unrelated minor changes:

  • Update github-labels.md to reflect use of Milestones instead of release-* labels.
  • Add a clarifying comment to address_resolver to show that this functionality is implemented even though the parameter is unused.
  • Resolve all xUnit1051 and xUnit1031 warnings and bump them to errors.

Issue Link

⚪ None

Features and Behaviour Changes

No behaviour changes.

Implementation

See summary.

Limitations

⚪ None

Testing

Lint passes. ✅

Related Issues

⚪ None

Checklist

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated and all checks pass.
  • CHANGELOG.md, README.md, DEVELOPER.md, and other documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

currantw added 3 commits July 29, 2026 07:39
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
@currantw currantw self-assigned this Jul 29, 2026
@currantw currantw added the dev Internal changes like cleanup, refactoring, or developer tools. label Jul 29, 2026
currantw added 3 commits July 29, 2026 15:29
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a small maintenance/cleanup set that updates project documentation, clarifies Rust FFI behavior, and modernizes tests to comply with stricter xUnit analyzer settings (notably eliminating blocking waits and consistently using TestContext.Current.CancellationToken).

Changes:

  • Updated unit/integration tests to avoid blocking task APIs (Task.WaitAll, Task.Wait) and to pass TestContext.Current.CancellationToken where applicable.
  • Clarified Rust FFI address_resolver initialization behavior in the connection request construction.
  • Updated docs/github-labels.md to reflect milestone-based scheduling and adjusted label documentation; tightened xUnit analyzer severities in .editorconfig.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/Valkey.Glide.UnitTests/ScriptTests.cs Converts concurrency tests to async Task and replaces blocking waits with await Task.WhenAll.
tests/Valkey.Glide.UnitTests/PubSubThreadSafetyTests.cs Adds TestContext.Current.CancellationToken to async operations and task scheduling in thread-safety tests.
tests/Valkey.Glide.UnitTests/PubSubPerformanceTests.cs Makes concurrent performance test async and removes blocking waits; uses cancellation token with task scheduling.
tests/Valkey.Glide.UnitTests/PubSubMessageHandlerTests.cs Converts concurrency/disposal tests to async and replaces blocking waits with await Task.WhenAll.
tests/Valkey.Glide.UnitTests/PubSubGracefulShutdownTests.cs Threads TestContext.Current.CancellationToken through channel operations and task scheduling.
tests/Valkey.Glide.UnitTests/PubSubFFIMemoryLeakTests.cs Replaces Task.WaitAll with await Task.WhenAll and adds cancellation token to task scheduling.
tests/Valkey.Glide.IntegrationTests/PubSubReconnectionTests.cs Uses TestContext.Current.CancellationToken with Task.Delay.
tests/Valkey.Glide.IntegrationTests/PubSubCallbackTests.cs Uses the test cancellation token when waiting on synchronization primitives.
tests/Valkey.Glide.IntegrationTests/IamAuthTests.cs Uses TestContext.Current.CancellationToken with Task.Delay calls.
tests/Valkey.Glide.IntegrationTests/ClientSideCacheTests.cs Uses TestContext.Current.CancellationToken with Task.Delay.
tests/Valkey.Glide.IntegrationTests/BatchTests.cs Removes blocking waits (Task.Wait) in favor of async delay + completion checks; updates one theory to async Task.
rust/src/ffi.rs Adds a clarifying comment and reorders address_resolver: None initialization in the request struct literal.
docs/github-labels.md Updates label workflow documentation to mention milestone scheduling and adds dev label description.
.editorconfig Bumps xUnit1031 and xUnit1051 analyzer severities to error.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/Valkey.Glide.UnitTests/PubSubThreadSafetyTests.cs Outdated
Comment thread docs/github-labels.md Outdated
Signed-off-by: currantw <taylor.curran@improving.com>
@currantw
currantw requested review from Aryex and xShinnRyuu July 29, 2026 23:33
currantw added 2 commits July 29, 2026 16:35
… into currantw/assorted-cleanup

Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Comment thread docs/github-labels.md
Signed-off-by: currantw <taylor.curran@improving.com>
@currantw currantw added this to the 1.2 milestone Jul 31, 2026
currantw added 2 commits July 31, 2026 09:45
… into currantw/assorted-cleanup

Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
@currantw
currantw merged commit 1adddc7 into valkey-io:main Jul 31, 2026
14 checks passed
@currantw
currantw deleted the currantw/assorted-cleanup branch July 31, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev Internal changes like cleanup, refactoring, or developer tools.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants