dev(clean): Fix labels, add address_resolver clarification, xUnit1051 - #489
Merged
Conversation
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
There was a problem hiding this comment.
Pull request overview
This PR is a small maintenance/cleanup set that updates project documentation, clarifies Rust FFI behavior, and modernizes tests to comply with stricter xUnit analyzer settings (notably eliminating blocking waits and consistently using TestContext.Current.CancellationToken).
Changes:
- Updated unit/integration tests to avoid blocking task APIs (
Task.WaitAll,Task.Wait) and to passTestContext.Current.CancellationTokenwhere applicable. - Clarified Rust FFI
address_resolverinitialization behavior in the connection request construction. - Updated
docs/github-labels.mdto reflect milestone-based scheduling and adjusted label documentation; tightened xUnit analyzer severities in.editorconfig.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Valkey.Glide.UnitTests/ScriptTests.cs | Converts concurrency tests to async Task and replaces blocking waits with await Task.WhenAll. |
| tests/Valkey.Glide.UnitTests/PubSubThreadSafetyTests.cs | Adds TestContext.Current.CancellationToken to async operations and task scheduling in thread-safety tests. |
| tests/Valkey.Glide.UnitTests/PubSubPerformanceTests.cs | Makes concurrent performance test async and removes blocking waits; uses cancellation token with task scheduling. |
| tests/Valkey.Glide.UnitTests/PubSubMessageHandlerTests.cs | Converts concurrency/disposal tests to async and replaces blocking waits with await Task.WhenAll. |
| tests/Valkey.Glide.UnitTests/PubSubGracefulShutdownTests.cs | Threads TestContext.Current.CancellationToken through channel operations and task scheduling. |
| tests/Valkey.Glide.UnitTests/PubSubFFIMemoryLeakTests.cs | Replaces Task.WaitAll with await Task.WhenAll and adds cancellation token to task scheduling. |
| tests/Valkey.Glide.IntegrationTests/PubSubReconnectionTests.cs | Uses TestContext.Current.CancellationToken with Task.Delay. |
| tests/Valkey.Glide.IntegrationTests/PubSubCallbackTests.cs | Uses the test cancellation token when waiting on synchronization primitives. |
| tests/Valkey.Glide.IntegrationTests/IamAuthTests.cs | Uses TestContext.Current.CancellationToken with Task.Delay calls. |
| tests/Valkey.Glide.IntegrationTests/ClientSideCacheTests.cs | Uses TestContext.Current.CancellationToken with Task.Delay. |
| tests/Valkey.Glide.IntegrationTests/BatchTests.cs | Removes blocking waits (Task.Wait) in favor of async delay + completion checks; updates one theory to async Task. |
| rust/src/ffi.rs | Adds a clarifying comment and reorders address_resolver: None initialization in the request struct literal. |
| docs/github-labels.md | Updates label workflow documentation to mention milestone scheduling and adds dev label description. |
| .editorconfig | Bumps xUnit1031 and xUnit1051 analyzer severities to error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: currantw <taylor.curran@improving.com>
… into currantw/assorted-cleanup Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
xShinnRyuu
reviewed
Jul 29, 2026
xShinnRyuu
approved these changes
Jul 29, 2026
Signed-off-by: currantw <taylor.curran@improving.com>
Aryex
approved these changes
Jul 31, 2026
… into currantw/assorted-cleanup Signed-off-by: currantw <taylor.curran@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A few unrelated minor changes:
github-labels.mdto reflect use of Milestones instead ofrelease-*labels.address_resolverto show that this functionality is implemented even though the parameter is unused.Issue Link
⚪ None
Features and Behaviour Changes
No behaviour changes.
Implementation
See summary.
Limitations
⚪ None
Testing
Lint passes. ✅
Related Issues
⚪ None
Checklist
This Pull Request is related to one issue.CHANGELOG.md,README.md,DEVELOPER.md, and other documentation files are updated.mainor releasemain, squash otherwise.