Fix SBOM to be valid SPDX 2.3 and add validation test - #158
Open
roshkhatri wants to merge 1 commit into
Open
Conversation
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114
The SBOM at
/usr/local/valkey.spdx.jsonwas missing fields that SPDX 2.3 marks mandatory, so strict scanners like Nexus IQ reject it with "SPDX content cannot be parsed".Changes:
dataLicense,documentNamespace,creationInfo, packagedownloadLocation,filesAnalyzed: false). Build time is stamped intocreatedand the namespace for a unique per-build document ID.valkey-sbom.jq(the old document came from bashbrew's auto-downloaded, gitignored stock helper).valkey-sbomtest validating the shipped SBOM with the spdx-tools validator.