Skip to content

Add Bundle Search Test Functionality - #98

Open
Nikhil-Manglore wants to merge 3 commits into
valkey-io:mainlinefrom
Nikhil-Manglore:update_tests
Open

Add Bundle Search Test Functionality#98
Nikhil-Manglore wants to merge 3 commits into
valkey-io:mainlinefrom
Nikhil-Manglore:update_tests

Conversation

@Nikhil-Manglore

@Nikhil-Manglore Nikhil-Manglore commented Mar 16, 2026

Copy link
Copy Markdown
Member

This PR adds valkey-search integration tests to the run.sh CI test script and runs them against the valkey-bundle Docker container in external server mode (VALKEY_EXTERNAL_SERVER=true).

A PR has been opened to the search repo as well to support this: valkey-io/valkey-search#908

I have explicitly listed 16 test files that are compatible with external server mode and test the core functionality of Valkey Search. I think this is more optimal than running all tests and skipping incompatible ones since then we don't have to monitor the new tests that Search will add that may not run against external servers or will need multiple servers to be running. The reason we skipped some tests is because many test files in valkey-search require cluster mode, replica setups, or internal server management that aren't supported when testing against an external container. Regardless these tests are very comprehensive in making sure search works with the bundle.

Additionally, we still currently run against the main branch of Search for all search versions because I need to check back porting for the external server fix after the PR I linked above is merged in. This is fine for now we can run all tests against the main branch of Search. In the near future i'll open a new PR so that each of the tests will be run against it's respective cloned branch in CI (1.0, 1.2 etc). That's why i have included the check in this PR to make sure the tests we are running exist in the branch first (since search versions before 1.2 won't include full text capabilities/tests)

Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
@roshkhatri

roshkhatri commented Mar 19, 2026

Copy link
Copy Markdown
Member

All the tests are failing, can you take a look at it @Nikhil-Manglore

Valkey: passed
JSON: passed
Bloom: passed
Search: failed

@Nikhil-Manglore

Copy link
Copy Markdown
Member Author

@roshkhatri Search needs to merge this in for them to run: valkey-io/valkey-search#908

@Nikhil-Manglore Nikhil-Manglore self-assigned this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants