Fix closeMetricsServer sending wrong ID to metrics process - #428
Merged
Conversation
Signed-off-by: ravjotb <ravjot.brar@improving.com>
nassery318
approved these changes
Jul 29, 2026
ravjotbrar
added a commit
that referenced
this pull request
Jul 29, 2026
Signed-off-by: ravjotb <ravjot.brar@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix metrics servers not shutting down on connection delete. The close request was sending the full connectionId (host-port-dbN) but the metrics process expects its own nodeId (host-port).
Problem:
When deleting a connection, closeMetricsServer sends a POST to the metrics process's /connection/close endpoint. The metrics process validates connectionId !== ownNodeId and rejects with 400 because:
Result: "Could not kill metrics server process" — orphaned metrics processes accumulate.
Fix:
Send nodeId (already computed at the top of the function) instead of connectionId in the request body:
body: JSON.stringify({ connectionId: nodeId })Testing:
connections still reference the same node