Clean specs#34
Open
WWWcool wants to merge 5 commits into
Open
Conversation
This commit cleans up the codebase by removing several unused type definitions and specifications across various modules, including `dmt_api_woody_utils`, `dmt_author_database`, `dmt_author_handler`, and others. The changes streamline the code and improve readability by eliminating unnecessary complexity. Additionally, some function specifications have been updated to reflect the current implementation accurately. No functional changes were made; this is purely a cleanup effort.
This commit updates the Erlang version from 28.0 to 28.5 in the .tool-versions file. It also modifies the Makefile to improve the eqwalizer task by iterating over modules defined in eqwalizer.modules. Additionally, the rebar.config file now references a specific commit for eqwalizer_support instead of the main branch. The static analysis GitHub Actions workflow has been enhanced by adding a new job for running Dialyzer, which includes steps for checking out the repository, loading environment variables, building the development image, and executing the Dialyzer analysis. No functional changes were made to the application code itself.
This commit adds type specifications to the `dmt_author`, `dmt_author_database`, `dmt_object`, and `dmt_object_id` modules, improving static analysis capabilities. The `eqwalizer.modules` file is updated to include the DMT modules for phase 1 checks. These changes aim to enhance code clarity and maintainability without altering existing functionality.
This commit updates the `eqwalizer.modules` file to include the `dmt_repository` module for phase 2a–2b checks. In the `dmt_repository.erl` file, several type specifications are added to improve static analysis, including types for worker, version, object references, and various error handling. Additionally, function specifications are defined for new API functions, enhancing clarity and maintainability. The `dmt_object.erl` file is also updated to export the `object_ref` type, ensuring consistency across modules. These changes aim to strengthen the codebase without altering existing functionality.
…figurations This commit adds new type exports to the `dmt_author_database`, `dmt_repository`, `dmt_object_id`, and `dmt_object` modules, improving the clarity and usability of type specifications across the codebase. Additionally, the `dmt_repository_filter_test` file is updated to suppress dialyzer warnings for several test functions, ensuring smoother test execution. These changes aim to enhance static analysis capabilities and maintainability without altering existing functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.