fix: use HookSucceeded with orphan propagation for oneShot ExternalSecret#15
Open
minmzzhang wants to merge 1 commit into
Open
fix: use HookSucceeded with orphan propagation for oneShot ExternalSecret#15minmzzhang wants to merge 1 commit into
minmzzhang wants to merge 1 commit into
Conversation
…cret Switch the oneShot hook-delete-policy from BeforeHookCreation to HookSucceeded so the keycloak-users ExternalSecret is removed as early as possible after syncing. Add PrunePropagationPolicy=orphan to prevent ArgoCD from cascade-deleting the K8s Secret when the ExternalSecret is pruned. Remove the one-shot label on the ExternalSecret itself since HookSucceeded handles its deletion. Rename the cleanup label from ztvp.io/cleanup to validatedpatterns.io/cleanup. Signed-off-by: Min Zhang <minzhang@redhat.com>
mlorenzofr
requested changes
May 26, 2026
Contributor
mlorenzofr
left a comment
mlorenzofr
left a comment
There was a problem hiding this comment.
I was testing it but I found some problems with the cleanup job
| namespace: {{ .Release.Namespace }} | ||
| {{- if .Values.externalSecrets.oneShot }} | ||
| labels: | ||
| {{ .Values.externalSecrets.secretCleanupLabel }}: one-shot |
Contributor
There was a problem hiding this comment.
The one-shot label has been removed here, but the job /cleanup-ephemeral-secrets still uses that label to delete the resource. We could also use {{ .Values.externalSecrets.secretCleanupLabel }}: delete, but there is no label on the resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the oneShot hook-delete-policy from BeforeHookCreation to HookSucceeded so the keycloak-users ExternalSecret is removed as early as possible after syncing. Add PrunePropagationPolicy=orphan to prevent ArgoCD from cascade-deleting the K8s Secret when the ExternalSecret is pruned. Remove the one-shot label on the ExternalSecret itself since HookSucceeded handles its deletion. Rename the cleanup label from ztvp.io/cleanup to validatedpatterns.io/cleanup.