fix(checkpoints): settle checkpoints past rollback window#505
Draft
github-actions[bot] wants to merge 1 commit into
Draft
fix(checkpoints): settle checkpoints past rollback window#505github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Confidence: 92% - merge after dependency-enabled CI passes.
Motivation
The fork uses a 1000-block rollback window, but
zebra-checkpointsstill treated checkpoints as settled after 100 blocks. This could generate a checkpoint inside a reorganization range Zebra would follow.Solution
Share
MAX_BLOCK_REORG_HEIGHTthroughzebra-chain, retain thezebra-stateAPI, and make the checkpoint generator use the 1000-block settlement margin. Nonessential documentation and test cleanup from upstream PR 10719 was omitted.Tests
Formatting and diff checks passed. Cargo check and clippy were blocked because the sandbox could not fetch the pinned
librustzcashrevision.Follow-up Work
Run targeted cargo check and workspace clippy with dependency access.
AI Disclosure
Codex was used for triage, focused implementation, and validation.
Revert Plan
Revert the three-file change to restore the 100-block checkpoint margin and state-local constant.
Upstream-Zebra-PR: 10719
Upstream-Zebra-Merge: 8767a91