fix(zakura): allow four unproven block probes#436
Closed
evan-forbes wants to merge 2 commits into
Closed
Conversation
6 tasks
evan-forbes
force-pushed
the
evan/zakura-single-peer-wedge
branch
3 times, most recently
from
July 3, 2026 17:14
cb49fac to
3856df1
Compare
evan-forbes
force-pushed
the
evan/zakura-single-peer-wedge
branch
from
July 3, 2026 17:21
3856df1 to
f2c98ef
Compare
evan-forbes
commented
Jul 3, 2026
| const BLOCK_PROGRESS_TIMEOUT_REQUESTS: u32 = 4; | ||
| /// Default `GetBlocks` probes sent to a new peer before it proves block-body progress. | ||
| pub const DEFAULT_BS_INITIAL_BLOCK_PROBE_REQUESTS: u32 = 1; | ||
| pub const DEFAULT_BS_INITIAL_BLOCK_PROBE_REQUESTS: u32 = 4; |
Author
Author
There was a problem hiding this comment.
see #441 where we're gathering more info to debug fully
evan-forbes
force-pushed
the
evan/zakura-single-peer-wedge
branch
from
July 3, 2026 17:32
f2c98ef to
2ef9f0c
Compare
evan-forbes
force-pushed
the
evan/zakura-single-peer-wedge
branch
from
July 3, 2026 17:36
2ef9f0c to
5a0333b
Compare
evan-forbes
marked this pull request as ready for review
July 3, 2026 18:18
Author
|
closing for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Split out of #435.
An unproven Zakura block-sync peer currently gets only one
GetBlocksprobe before it must deliver an accepted body to receive more work. That is too brittle for a single-peer sync path: one lost/delayed initial response can leave the peer capped until the no-progress liveness deadline disconnects it.Regtest also needed a shorter body-sync stall watchdog so a stalled node reaches the fallback within the e2e test budget.
No linked issue.
Solution
GetBlocksrequest to four.Tests
cargo fmt --all -- --checkcargo test -p zebra-network block_livenessSpecifications & References
Follow-up Work
None planned.
AI Disclosure
PR Checklist
type(scope): description