fix(inbound): retry duplicate block advertisers#320
Open
evan-forbes wants to merge 1 commit into
Open
Conversation
evan-forbes
force-pushed
the
codex/inbound-block-fallbacks
branch
from
June 29, 2026 20:57
e283fad to
20193ab
Compare
evan-forbes
marked this pull request as ready for review
June 30, 2026 00:03
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2baa4e038
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
evan-forbes
force-pushed
the
codex/inbound-block-fallbacks
branch
2 times, most recently
from
July 1, 2026 22:33
aa11e16 to
5c1cf16
Compare
evan-forbes
force-pushed
the
codex/inbound-block-fallbacks
branch
from
July 1, 2026 22:53
5c1cf16 to
0171eb9
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: N/A
When multiple peers advertised the same gossiped block, Zebra previously kept only the first advertiser. A malicious first advertiser could race honest peers, then timeout or return malformed data, causing the gossip download to fail even though other peers had also advertised the block.
Solution
RouterError::Blockverifier errors.Validation
cargo test -p zebrad components::inboundcargo fmt --all -- --checkIn this environment the
zebradtests were run withCXXFLAGS='-include cstdint'to work around a locallibrocksdb-sysC++ include issue.AI Disclosure
Used OpenAI Codex to audit, implement, and test this change.