Free Zcash batch review memory before signing#35
Closed
czarcas7ic wants to merge 3 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release the Zcash batch review container, navigation controls, and sign slider before opening the signature QR view so their LVGL allocations do not overlap and exhaust SRAM. The production limit remains 50 PCZTs.
An instrumented ForgeBox build temporarily raised the cap and completed an exact 58-PCZT public-testnet migration request as a stress test. The prior build exhausted the SRAM heap after PIN entry; with this lifecycle change, the run reached signing completion and cleanup with 41,408 bytes of minimum dynamic SRAM heap headroom and 5,614,616 bytes of minimum PSRAM headroom.
cargo fmt --checkand all 17 cypherpunk Zcash Rust tests pass.