Reject existing Zcash batch signatures#34
Closed
czarcas7ic wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject Zcash batch requests that already contain Orchard or Ironwood spend authorization signatures. Batch responses are defined as compact signatures generated by the device, so accepting incoming signature fields could let a mixed-action request report success while returning bytes that the device did not produce.
The check is limited to batch review and signing. Generic PCZT signing keeps its collaborative and finalized dummy behavior, and the cached signability decision remains bound to the complete normalized PCZT digest.
Test plan
cargo +nightly-2025-07-01 test -p app_zcash --lockedcargo +nightly-2025-07-01 test -p app_zcash --no-default-features --features multi_coins --lockedcargo +nightly-2025-07-01 test -p rust_c --no-default-features --features simulator-cypherpunk --lib -- zcash common::urcargo +nightly-2025-07-01 fmt --all -- --checkcargo +nightly-2025-07-01 metadata --locked --no-deps --format-version 1python3 build.py -t cypherpunk -o simulator