Speed up Zcash batch processing and show a loading hint#26
Closed
czarcas7ic wants to merge 1 commit into
Closed
Conversation
czarcas7ic
marked this pull request as ready for review
July 10, 2026 07:43
czarcas7ic
force-pushed
the
adam/zcash-reviewed-batch-compact-response
branch
from
July 10, 2026 20:27
3539243 to
2dd71c3
Compare
czarcas7ic
force-pushed
the
adam/zcash-batch-performance
branch
from
July 10, 2026 20:27
cb8f50a to
73d5aef
Compare
czarcas7ic
changed the title
czarcas7ic
force-pushed
the
adam/zcash-batch-performance
branch
from
July 11, 2026 10:40
2933ea2 to
fd13888
Compare
czarcas7ic
force-pushed
the
adam/zcash-reviewed-batch-compact-response
branch
from
July 12, 2026 06:50
f068f5b to
2a86bb6
Compare
czarcas7ic
force-pushed
the
adam/zcash-batch-performance
branch
from
July 13, 2026 05:51
2a8b36c to
be65765
Compare
Author
|
Closing since they have been merged into mega upstream already, but we should still get these commit by commit reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the PCZT-owned batch layer and isolates the performance work that was previously present only in the integration branch.
The batch path now shares caches for the spend authorizing key, UFVK, wallet key, and address ownership across PCZTs; reuses one check context for the full sweep; and retains normalized parsed and display state so review and signing do not repeat expensive work. The spend authorizing key cache is one request-scoped inline slot. It reuses the selected account key across PCZTs and pools, scrubs the old key before replacement, scrubs the final key before response encoding, and zeroizes the intermediate spending key.
Because large batches can still take noticeable time on-device, the Zcash batch view adds a localized subtitle to the existing nonanimated loading hint so users know the operation may take a few minutes. The subtitle-capable helper is used only by the Zcash batch flow; single Zcash transactions and other transaction loading screens retain their existing behavior.
Device policy and signature verification remain unchanged.