chore(cbind): nim-ffi migration [9/9] — flip to libp2p.nim, delete legacy cbind#2780
Draft
gmelodie wants to merge 1 commit into
Draft
chore(cbind): nim-ffi migration [9/9] — flip to libp2p.nim, delete legacy cbind#2780gmelodie wants to merge 1 commit into
gmelodie wants to merge 1 commit into
Conversation
This was referenced Jul 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/cbind/ffi/08-relay-peerstore-metrics #2780 +/- ##
==============================================================================
- Coverage 81.15% 81.13% -0.03%
==============================================================================
Files 170 170
Lines 31027 31027
Branches 13 12 -1
==============================================================================
- Hits 25180 25173 -7
- Misses 5847 5854 +7 🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nim-ffi cbind migration — PR train
Part 9 of a 9-PR train that replaces the hand-rolled
cbind/C bindings with the generated nim-ffi codegen, landing it domain by domain so each PR stays reviewable and CI-green (build the FFI lib + generate bindings + build/run examples).Targets
chore/cbind/ffi/08-relay-peerstore-metrics(stacked).This PR does
git mv cbind/libp2p_ffi.nim cbind/libp2p.nim, replacing the legacy file (recorded as a rename).alloc.nim,ffi_types.nim,types.nim,libp2p.h, the wholelibp2p_thread/tree, andexamples/cbindings.c..#cbind-ffinix target andc-bindings-ffiCI job back into the single final flow.linters.ymland the copilot instructions.Review artifact: Net header is unchanged from [8/9] — this PR is deletion + rename + CI/nix consolidation, not new API.