Reduce test-lumo Lumo to a Vaadin-free stub#24439
Draft
Artur- wants to merge 1 commit into
Draft
Conversation
Many test modules pull in flow-test-lumo just so Flow's classpath detection (AbstractDependenciesScanner.LUMO) finds a class named com.vaadin.flow.theme.lumo.Lumo and treats it as the default theme. Until now that class also declared four annotations that pulled in @vaadin/vaadin-themable-mixin and @vaadin/vaadin-lumo-styles plus their companion CssImport/JsModule. The classpath-detection contract only needs the FQN, AbstractTheme implementation, and LIGHT/DARK variants. Drop the Vaadin npm declarations; tests that actually need to verify Lumo CSS variables can declare those deps themselves. Part of removing TestVersion.VAADIN usages. The downstream impact will surface in CI: any IT that visually checks Lumo styling on this code path will start failing and can be addressed per-module.
|
Test Results 1 410 files - 11 1 410 suites - 11 1h 18m 26s ⏱️ - 4m 54s For more details on these failures and errors, see this check. Results for commit aa293f4. ± Comparison against base commit 9c9ca5f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many test modules pull in flow-test-lumo just so Flow's classpath detection (AbstractDependenciesScanner.LUMO) finds a class named com.vaadin.flow.theme.lumo.Lumo and treats it as the default theme. Until now that class also declared four annotations that pulled in @vaadin/vaadin-themable-mixin and @vaadin/vaadin-lumo-styles plus their companion CssImport/JsModule.
The classpath-detection contract only needs the FQN, AbstractTheme implementation, and LIGHT/DARK variants. Drop the Vaadin npm declarations; tests that actually need to verify Lumo CSS variables can declare those deps themselves.
Part of removing TestVersion.VAADIN usages. The downstream impact will surface in CI: any IT that visually checks Lumo styling on this code path will start failing and can be addressed per-module.