Skip to content

fix: ios home screen app height#24435

Open
jouni wants to merge 2 commits into
mainfrom
fix/ios-home-screen-app
Open

fix: ios home screen app height#24435
jouni wants to merge 2 commits into
mainfrom
fix/ios-home-screen-app

Conversation

@jouni
Copy link
Copy Markdown
Member

@jouni jouni commented May 25, 2026

Fixes #5576

We can consider adding a feature to the PWA annotation later, if there are requests for that. For now, I assume this fix is enough for the majority of our users.

The bootstrap page update makes sure the app covers the entire viewport height on iOS when opened as a standalone/home screen app.

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented May 25, 2026

CLA assistant check
All committers have signed the CLA.

The only acceptable values are `default`, `black`, and `black-translucent`. The `black-translucent` option allows the application to extend under the status bar area.
@jouni jouni force-pushed the fix/ios-home-screen-app branch from 8f2ed20 to 099c819 Compare May 25, 2026 08:58
@github-actions
Copy link
Copy Markdown

Test Results

 1 420 files  ±0   1 420 suites  ±0   1h 21m 4s ⏱️ -55s
 9 999 tests ±0   9 931 ✅ ±0  68 💤 ±0  0 ❌ ±0 
10 471 runs  ±0  10 402 ✅ ±0  69 💤 ±0  0 ❌ ±0 

Results for commit 099c819. ± Comparison against base commit 92cc26c.

@mshabarov mshabarov requested a review from heruan May 25, 2026 11:34
mstahv
mstahv previously approved these changes May 25, 2026
Copy link
Copy Markdown
Member

@mstahv mstahv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍Looks very good! I'm assuming Jouni did the homework and tested with various versions/environments.

I'm currrently doing effectively same setting for "apple-mobile-web-app-status-bar-style" via weird JS hack as it is basically impossible to override on the server-side. Otherwise my app would simply look bad, now it's beatiful background photo can spread to the whole screen estate.

I don't remember if "lvh" height is in use in any of my apps, but I trust the expertise of Jouni here.

heruan
heruan previously approved these changes May 26, 2026
@jouni
Copy link
Copy Markdown
Member Author

jouni commented May 26, 2026

I'm assuming Jouni did the homework and tested with various versions/environments.

Well, you’re kinda right – I did that, but only after I opened the PR. Setting up a working Android emulator setup took a bit more effort, and I only now got to testing it. And apparently there is an issue. So hold on for a moment before merging.

Update: done.

Comment thread flow-server/src/main/resources/com/vaadin/flow/server/frontend/index.html Outdated
@jouni jouni dismissed stale reviews from heruan and mstahv via 260591d May 26, 2026 10:44
@jouni jouni force-pushed the fix/ios-home-screen-app branch from 099c819 to 260591d Compare May 26, 2026 10:44
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@PWA themeColor should not affect apple-mobile-web-app-status-bar-style

3 participants